13 Jun
2017
13 Jun
'17
2:06 p.m.
On 06/13/2017 06:22 AM, Andrea Bolognani wrote:
On Mon, 2017-06-12 at 22:02 -0400, Laine Stump wrote:
Moving the check and rewriting it this way doesn't alter the current behavior, but will allow us to special-case pci-root down the line.
But this function should never be called for a controller with model='pci-root'?
<spoilers> It will, later on ;) </spoilers>
Right. My brain is *slowly* waking up. So ACK, or Reviewed-by: Laine Stump <laine@laine.org> if you prefer. (Looking back at that function, it could be made a lot more compact by combining all the different models' checks for modelName != NONE as well. Again, that's irrelevant to your patches).