Re: [libvirt] [PATCH 3/6] tests: qemumonitorjson: Don't do multiple tests in one virTestRun

On 09/27/2016 12:39 PM, Peter Krempa wrote:

The chardev attach test would do all the tests in one virTestRun instance. If one sub-test failed then the test would report failure improperly and the error would be hard to debug since the error pointer was overwritten. --- tests/qemumonitorjsontest.c | 147 ++++++++++++++++++++++++++++++-------------- 1 file changed, 102 insertions(+), 45 deletions(-)

ACK - seems reasonable (not a pleasant diff to read) John