Re: [libvirt] [PATCH 09/10] nodeinfo: Use a bitmap to keep track of node CPUs

> + /* Iterate over all CPUs in the node, in ascending order */ > + for (cpu = 0; cpu < npresent_cpus; cpu++) { > > - if (!virBitmapIsBitSet(present_cpumap, cpu)) > + /* Skip CPUs that are not part of the current node */ > + if (!virBitmapIsBitSet(node_cpus_map, cpu)) Perhaps you can use virBitmapNextSetBit to simplify the iteration. > continue; > > if (!virBitmapIsBitSet(online_cpus_map, cpu)) { ACK with or without the iteration modified.