Re: [Libvir] diagnose invalid domain ID numbers (and invalid integers, in general)
On Sat, Nov 17, 2007 at 05:09:51PM -0500, Daniel Veillard wrote:
On Sat, Nov 17, 2007 at 01:17:34PM +0000, Daniel P. Berrange wrote:
> On Fri, Nov 09, 2007 at 10:30:15PM +0100, Jim Meyering wrote:
> > +TESTS_ENVIRONMENT = \
> > + abs_top_builddir='$(abs_top_builddir)' \
> > + abs_top_srcdir='$(abs_top_srcdir)' \
> > + $(VG)
> > +
>
> I've had to make a change to this rule. automake-1.9 which is in Fedora 6,
> RHEL-5 and Debian does not provide any abs_* variable definitions at all.
> These were new in automake-1.10
One thing I noticed is that if the environment variable is not defined
the test programs just exits without output, I changed a couple of them
when doing the tests for <shareable/> in my tree to fprintf to stderr
the fact that the environment variable is missing, I will try to commit
this next week,
One other way would be to set the abs_top_srcdir at compile time by
passing in -Dabs_top_srcdir instead of setting an env var at runtime.
It is not like this stuff changes once you've run 'configure', so we
don't particularly need the flexibility of a runtime setting.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|