Re: [Libvir] PATCH 1/3: Split out simple event loop

On Mon, Jun 18, 2007 at 05:49:59AM -0400, Daniel Veillard wrote: > > - return ret; > > + if (ret != 0) > > + server->shutdown = 1; > > } > > is asynchronous error handling really better there ? It is unavoidable in this context actually, since this is a callback invoked from within the event loop, there isn't any meaningful caller to deal with a return value. The event loop itself checks on the server->shutdown flag on each iteration, so the end result is the same as previous code.