On 02/11/2013 04:40 PM, Daniel P. Berrange wrote:
I'm not a fan of this approach. The capabilities data is reflecting what the QEMU binary is capable of supporting, *regardless* of what guest config is chosen.
not convinced this is the best possible definition ... we would have seen more issues with it if the machine type would really have had a meaning on other architectures, e.g., if -M isapc would not allow to instantiate PCI devices. But since...
The decision about whether to use S390 or CCW based on the machine type value, should be made by the internal method at the point when it actually assigns addresses, not when we create the capabilities initially.
...I can certainly use the vm definition to figure out which address type to choose that should work. Let me run a few tests to prove that and I will come back with a V3 for 3-5/5 in the next couple of days. -- Mit freundlichen Grüßen/Kind Regards Viktor Mihajlovski IBM Deutschland Research & Development GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Dirk Wittkopp Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294