Re: [libvirt] [Qemu-devel] [PATCHv2] Don't log an internal error when the guest hasn't updated balloon stats

Copying Luiz...

>> src/qemu/qemu_monitor_json.c | 18 ++++++++++++++---- >> 1 file changed, 14 insertions(+), 4 deletions(-) > >> + if ((data = virJSONValueObjectGet(reply, "error"))) { >> + const char *klass = virJSONValueObjectGetString(data, "class"); >> + const char *desc = virJSONValueObjectGetString(data, "desc"); >> >> - if (ret < 0) >> + if (STREQ_NULLABLE(klass, "GenericError") && >> + STREQ_NULLABLE(desc, "guest hasn't updated any stats yet")) { You snipped so much of the diff that I have trouble finding the place this applies.

Is "no stats yet" really an error? Libvirt has done nothing wrong, and I'd argue the guest hasn't done anything wrong, either. Should we simply return an empty result? Like "cat" on a file that hasn't gotten its data, yet.