Re: [libvirt] [PATCH 7/7] Add a test for virStorageBackendISCSIScanTargets
On Wed, Mar 12, 2014 at 02:08:17PM +0100, Ján Tomko wrote:
diff --git a/tests/storageiscsidata/iscsiadm_sendtargets
b/tests/storageiscsidata/iscsiadm_sendtargets
new file mode 100644
index 0000000..acea8ee
--- /dev/null
+++ b/tests/storageiscsidata/iscsiadm_sendtargets
@@ -0,0 +1,6 @@
+10.20.30.40:3260,1 iqn.2004-06.example:example1:iscsi.test
+10.20.30.40:3260,1 iqn.2005-05.example:example1:iscsi.hello
+10.20.30.40:3260,1 iqn.2006-04.example:example1:iscsi.world
+10.20.30.40:3260,1 iqn.2007-04.example:example1:iscsi.foo
+10.20.30.40:3260,1 iqn.2008-04.example:example1:iscsi.bar
+10.20.30.40:3260,1 iqn.2009-04.example:example1:iscsi.seven
If we use the callback approach I suggested, then this data can just
be a constant string inlined in the storageiscsitest.c file. I think
that is preferrable since we're not likely to need to have 100's of
external data files as we do for other tests
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|