During Peter's review of the recent IOThreads Add/Del series he noted
two outstanding issues:
1. The qemuDomainParseIOThreadAlias should be done within the context
of the qemuMonitorJSONGetIOThreads and return an iothread_id instead
of a name which must be parsed by everyone
2. The order of checks in qemuProcessDetectIOThreadPIDs to compare the
returned niothreads against zero, should have been done after the
comparison of whether the number returned matches what the domain
expects. If the domain had expected some number of iothreads and none
were returned, then that needs to be noted.
For review details, see:
http://www.redhat.com/archives/libvir-list/2015-April/msg01361.html
John Ferlan (2):
qemu: Remove need for qemuDomainParseIOThreadAlias
qemu: qemuProcessDetectIOThreadPIDs invert checks
src/qemu/qemu_command.c | 17 -----------------
src/qemu/qemu_command.h | 3 ---
src/qemu/qemu_driver.c | 9 ++-------
src/qemu/qemu_monitor.c | 1 -
src/qemu/qemu_monitor.h | 2 +-
src/qemu/qemu_monitor_json.c | 7 ++++++-
src/qemu/qemu_process.c | 23 ++++++++++-------------
tests/qemumonitorjsontest.c | 12 ++++++------
8 files changed, 25 insertions(+), 49 deletions(-)
--
2.1.0