Re: [libvirt] [PATCH] vmx: Support persistent CPU shares
2011/4/4 Daniel Veillard <veillard(a)redhat.com>:
On Sun, Apr 03, 2011 at 02:43:55PM +0200, Matthias Bolte wrote:
> ---
> src/vmx/vmx.c | 43 ++++++++++++++++++++++
> tests/vmx2xmldata/vmx2xml-case-insensitive-1.vmx | 2 +-
> tests/vmx2xmldata/vmx2xml-case-insensitive-1.xml | 3 ++
> tests/vmx2xmldata/vmx2xml-case-insensitive-2.xml | 3 ++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.vmx | 2 +-
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-1.xml | 3 ++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-4.xml | 3 ++
> tests/vmx2xmldata/vmx2xml-esx-in-the-wild-5.xml | 3 ++
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.vmx | 1 +
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-1.xml | 3 ++
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.vmx | 1 +
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-4.xml | 3 ++
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-5.vmx | 1 +
> tests/xml2vmxdata/xml2vmx-esx-in-the-wild-5.xml | 3 ++
> 14 files changed, 72 insertions(+), 2 deletions(-)
>
ACK, while nice, it may be a bit late for 0.9.0, okay to wait for the
next cycle ? We already have this for xen and qemu, seeing it for ESX
confirms the design is fine, which is the most important from my point
of vue :-)
Daniel
Sure, this can wait until 0.9.1. On the ESX side the shares value is
persistent anyway. This patch just exposes it as persistent in libvirt
too.
Matthias