Re: [libvirt] [PATCH 0/7] Test parsing of iscsiadm output
On Wed, Mar 12, 2014 at 02:08:10PM +0100, Ján Tomko wrote:
Introduce virCommandSetMockOutputFile for faking output of
asynchronous commands and use it to test parsing of iscsiadm
output in virStorageBackendISCSISession and
virStorageBackendISCSIScanTargets
Ján Tomko (7):
Change virStorageBackendISCSISession 'probe' arg to bool
Introduce virStoragePoolSourceDeviceClear
Use size_t for ndevice in pool source definition
Introduce vircommandpriv.h for functions used by tests
Add virCommandSetMockOutputFile
Add test for virStorageBackendISCSISession
Add a test for virStorageBackendISCSIScanTargets
Strangely I've still not received patch 2, but ACK to that patch
based on what's in the mailing list archives.
If you want to do any more work in this area, I think one other good
idea would be to introduce a src/util/viriscsi.{c,h} helper API which
exposes a set of APIs for core iSCSI operations we need. This would
isolate all the iscsiadm command code in one place, separated from the
storage backend implementation, so both sides of the code would be
easier to follow.
I think I'd extend this API to other stuff the storage backends do
too. eg a virlvm.{c,h} and a virscsi.{c,h} etc, to again isolate code
that is invoking commands + parsing their output, from the code that
actually uses this functionality.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|