Re: [libvirt] [PATCH] Properly handle -h / -V for --help/--version aliases in virtlockd/libvirtd

From: "Daniel P. Berrange" <berrange(a)redhat.com&gt; The virtlockd/libvirtd daemons had listed '?' as the short option for --help. getopt_long uses '?' for any unknown option. We want to be able to distinguish unknown options (which use EXIT_FAILURE) from correct usage of help (which should use EXIT_SUCCESS). Thus we should use 'h' as a short option for --help. Also add this to the man page docs The virtlockd/libvirtd daemons did not list any short option for the --version arg. Add -V as a valid short option, since -v is already used for --verbose. Signed-off-by: Daniel P. Berrange <berrange(a)redhat.com&gt; --- daemon/libvirtd.c | 31 ++++++++++++++----------------- daemon/libvirtd.pod.in | 4 ++++ src/locking/lock_daemon.c | 29 +++++++++++++---------------- src/locking/virtlockd.pod.in | 6 +++++- 4 files changed, 36 insertions(+), 34 deletions(-)

-enum { - OPT_VERSION = 129 -};