Re: [PATCH RFC v3 03/16] config: Introduce ThrottleGroup and corresponding XML parsing

> +static virDomainThrottleGroupDef * > +virDomainThrottleGroupDefParseXML(xmlNodePtr node, > + xmlXPathContextPtr ctxt) > +{ > + g_autoptr(virDomainThrottleGroupDef) group = g_new0(virDomainThrottleGroupDef, 1); > + > + VIR_XPATH_NODE_AUTORESTORE(ctxt) > + ctxt->node = node; > + > + PARSE_THROTTLEGROUP(total_bytes_sec); > + PARSE_THROTTLEGROUP(read_bytes_sec); > + PARSE_THROTTLEGROUP(write_bytes_sec); > + PARSE_THROTTLEGROUP(total_iops_sec); > + PARSE_THROTTLEGROUP(read_iops_sec); > + PARSE_THROTTLEGROUP(write_iops_sec); > + > + PARSE_THROTTLEGROUP(total_bytes_sec_max); > + PARSE_THROTTLEGROUP(read_bytes_sec_max); > + PARSE_THROTTLEGROUP(write_bytes_sec_max); > + PARSE_THROTTLEGROUP(total_iops_sec_max); > + PARSE_THROTTLEGROUP(read_iops_sec_max); > + PARSE_THROTTLEGROUP(write_iops_sec_max); > + > + PARSE_THROTTLEGROUP(size_iops_sec); > + > + PARSE_THROTTLEGROUP(total_bytes_sec_max_length); > + PARSE_THROTTLEGROUP(read_bytes_sec_max_length); > + PARSE_THROTTLEGROUP(write_bytes_sec_max_length); > + PARSE_THROTTLEGROUP(total_iops_sec_max_length); > + PARSE_THROTTLEGROUP(read_iops_sec_max_length); > + PARSE_THROTTLEGROUP(write_iops_sec_max_length); I'd prefer if we had only one copy of the code parsing this and the equivalent disk throttling data so that the code doesn't need to be duplicated. The cleanup can be done as a followup though.