Re: [libvirt] [PATCHv2] virsh: Cleanup virsh -V output

On 2012年06月28日 11:37, Eric Blake wrote: > From: Doug Goldstein<cardoe(a)cardoe.com> > > Fixed up virsh -V output by removing invalid WITH_PROXY& WITH_ONE > checks, adding several missing checks, and fixing the DTrace check. > > Signed-off-by: Doug Goldstein<cardoe(a)cardoe.com> > Signed-off-by: Eric Blake<eblake(a)redhat.com> > --- >

> @@ -20838,6 +20841,9 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED) > #ifdef WITH_NWFILTER > vshPrint(ctl, " Nwfilter"); > #endif > +#ifdef WITH_INTERFACE > + vshPrint(ctl, " Interface"); > +#endif $ grep WITH_INTERFACE * -r daemon/libvirtd.c:# ifdef WITH_INTERFACE tests/virdrivermoduletest.c:#ifdef WITH_INTERFACE WITH_INTERFACE is never defined, and I think it's mispelling of WITH_NETCF. So instead of add WITH_INTERFACE here, we need to fix the WITH_INTERFACE use in the two .c files. Or Change WITH_NETCF into WITH_INTERFACE overall. Personally I like the later more, as "interface" is the term we use across the project.