On 06/27/2012 09:52 PM, Osier Yang wrote:
On 2012年06月28日 11:37, Eric Blake wrote:
From: Doug Goldstein<cardoe@cardoe.com>
Fixed up virsh -V output by removing invalid WITH_PROXY& WITH_ONE checks, adding several missing checks, and fixing the DTrace check.
Signed-off-by: Doug Goldstein<cardoe@cardoe.com> Signed-off-by: Eric Blake<eblake@redhat.com> ---
@@ -20838,6 +20841,9 @@ vshShowVersion(vshControl *ctl ATTRIBUTE_UNUSED) #ifdef WITH_NWFILTER vshPrint(ctl, " Nwfilter"); #endif +#ifdef WITH_INTERFACE + vshPrint(ctl, " Interface"); +#endif
$ grep WITH_INTERFACE * -r daemon/libvirtd.c:# ifdef WITH_INTERFACE tests/virdrivermoduletest.c:#ifdef WITH_INTERFACE
WITH_INTERFACE is never defined, and I think it's mispelling of WITH_NETCF. So instead of add WITH_INTERFACE here, we need to fix the WITH_INTERFACE use in the two .c files. Or Change WITH_NETCF into WITH_INTERFACE overall. Personally I like the later more, as "interface" is the term we use across the project.
Oh my, I think you're right. I'll fix that in a followup patch, and have pushed this one using WITH_NETCF instead. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org