Re: [libvirt] [PATCH 14/16] docs: hacking: amend label indenting rules
On Sat, 2019-10-19 at 00:36 +0200, Ján Tomko wrote:
- Top-level labels should be indented by one space (putting them
on
- the beginning of the line confuses function context detection in git):
+ Top-level labels are indented by one space, since no indentation
+ used to confuse function context detection in git. This rule may
+ be re-evaluated in the future since git handles it correctly now
+ and not all code formatting tools support this setting:
</p>
I see[1] that Dan has already ACKed this, but personally I don't see
much of a point in merging it: the HACKING file documents our
*current* guidelines, not what they might look like in the future,
and as of today syntax-check will error out if goto labels are not
indented by exactly one space; if and when that will change, that
will be the perfect time to update this file as well.
Please consider dropping this patch before pushing your series.
[1] Through the browser-accessible archive, since regular delivery
appears to be broken (at least for me).
--
Andrea Bolognani / Red Hat / Virtualization