Re: [libvirt] [PATCH v3 11/30] conf: Format and parse NVMe type disk
On 12/10/19 12:43 AM, Cole Robinson wrote:
On 12/2/19 9:26 AM, Michal Privoznik wrote:
> To simplify implementation, some restrictions are added. For
> instance, an NVMe disk can't go to any bus but virtio and has to
> be type of 'disk' and can't have startupPolicy set.
>
> Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
Reviewed-by: Cole Robinson <crobinso(a)redhat.com>
Arguably the nvme->namespace == 0 should be in a Validate callback, but
it's extremely minor
Fixed. Initially, I thought that namespace == 0 is invalid XML but I can
argue both ways. And since you have inclination to the Validate callback
I've moved the check there.
Michal