Re: [libvirt] [PATCH] qemu: Allow enabling/disabling features with host-passthrough
On Mon, Jan 12, 2015 at 02:21:35PM +0100, Martin Kletzander wrote:
QEMU supports feature specification with -cpu host and we just skip
using that. Since QEMU developers themselves would like to use this
feature, this patch modifies the code to work.
This is actually useful in other ways too - eg there are some CPU flags
which won't exist in your host CPU, but which are none the less useful
to be able to enable/disable in passthrough mode.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1178850
Signed-off-by: Martin Kletzander <mkletzan(a)redhat.com>
---
docs/formatdomain.html.in | 5 +-
docs/schemas/domaincommon.rng | 67 ++++++++--------------
src/conf/cpu_conf.c | 53 +++++++++--------
src/qemu/qemu_command.c | 21 ++++---
...emuxml2argv-cpu-host-passthrough-features.args} | 2 +-
...qemuxml2argv-cpu-host-passthrough-features.xml} | 22 +------
tests/qemuxml2argvtest.c | 2 +-
tests/qemuxml2xmltest.c | 1 +
8 files changed, 71 insertions(+), 102 deletions(-)
rename tests/qemuxml2argvdata/{qemuxml2argv-cpu-host-passthrough-features-invalid.args
=> qemuxml2argv-cpu-host-passthrough-features.args} (91%)
rename tests/qemuxml2argvdata/{qemuxml2argv-cpu-host-passthrough-features-invalid.xml
=> qemuxml2argv-cpu-host-passthrough-features.xml} (57%)
ACK
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|