Re: [libvirt] [PATCH 1/3] command: Add virCommandEnvAddFormat
On 05/05/2011 02:44 PM, Cole Robinson wrote:
Similar to virCommandArgAddFormat. We will use this shortly.
Signed-off-by: Cole Robinson <crobinso(a)redhat.com>
---
src/libvirt_private.syms | 1 +
src/util/command.c | 30 ++++++++++++++++++++++++++++++
src/util/command.h | 7 +++++++
3 files changed, 38 insertions(+), 0 deletions(-)
Looks fine as-is, but now that we have it, I'm wondering if we should
simplify:
void
virCommandAddEnvPair(virCommandPtr cmd, const char *name, const char *value)
{
virCommandAddEnvFormat(cmd, "%s=%s", name, value);
}
ACK
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)