Re: [PATCH 2/2] qemu: Validate TPM TIS device
On Thu, 2021-02-11 at 08:44 -0700, Jim Fehlig wrote:
On 2/11/21 3:37 AM, Andrea Bolognani wrote:
> On Wed, 2021-02-10 at 10:34 -0700, Jim Fehlig wrote:
> > + if (!ARCH_IS_X86(def->os.arch) && (def->os.arch !=
VIR_ARCH_AARCH64)) {
> > + virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
> > + _("TPM model %s is only available for "
> > + "x86 and aarch64 guests"),
>
> Please don't split the error message into two separate lines
I'm surprised that slipped through my copy and paste since I've always preferred
errors on one line for easy searching. We have a lot of split error messages
throughout the code. This file is particularly bad. Is there any desire to fix
existing cases, or just avoid new ones?
I don't think we're particularly interested in going back and
altering existing messages, and most importantly in the churn doing
so would generate :)
--
Andrea Bolognani / Red Hat / Virtualization