On Tue, Oct 23, 2012 at 01:46:46PM -0400, Laine Stump wrote:
This is a repost of
https://www.redhat.com/archives/libvir-list/2012-October/msg01080.html
with PATCH 03/12 squashed into 01/12. There are no other changes.
************************************
PATCH 01/11 defines a couple new macros/functions to simplify inserting/deleting items in the middle of an array. The remaining patches switch over various pieces of existing code to use these new macros rather than directly calling memmove, etc.
There are several other places where these macros could *almost* be used, except that they use the model of pre-allocating the larger array, then performing a bunch of operations (that may fail) and then finally move items around in the array and adjust its count. I'm wondering if I should add a flags arg to these to allow for specifying a "Don't realloc" flag - when it was given, the memory allocation operation would be presumed already done (in the case of insert) or to be done after return (for delete). Any opinions on that? (such as maybe "that's too many options!")
I haven't reviewed the patches in detail, but I have to say that I like the addition of these array helpers. Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|