Re: [libvirt] Minor compile failure on OSX for libvirt 2.0.0

On Tue, Jul 19, 2016 at 06:30:47PM +0100, Justin Clift wrote: > On 19 Jul 2016, at 17:58, Andrea Bolognani <abologna(a)redhat.com&gt; wrote:

>> Did you manage to build and run libvirt succesfully with the >> patch I posted? > > Not yet. It barfed at me due to a system config problem which I need > to investigate and haven't done yet. Probably get around to it later > today. :) > > Thinking out loud... is the systemd code compiled for BSD? > > Guessing not (without checking :>), so there's probably some kind of > #ifdef to automatically exclude it. If that's how things are setup at > present, would the optimal approach be to adjust such an #ifdef to also > exclude OSX? > Unfortunately the systemd code is compiled everywhere. We use no library or header file. AFAIK the only way we communicate with systemd is DBus (and one socket maybe), anyway if that's not available we just fallback without an error, so the code is designed to work with or without systemd, no need to recompile anything. OTOH it adds unused code for platforms where it won't be used at all. At least for now ;)