On 20 Jul 2016, at 12:21, Martin Kletzander <mkletzan@redhat.com> wrote:
On Tue, Jul 19, 2016 at 06:30:47PM +0100, Justin Clift wrote:
On 19 Jul 2016, at 17:58, Andrea Bolognani <abologna@redhat.com> wrote: <snip>
Did you manage to build and run libvirt succesfully with the patch I posted?
Not yet. It barfed at me due to a system config problem which I need to investigate and haven't done yet. Probably get around to it later today. :)
Thinking out loud... is the systemd code compiled for BSD?
Guessing not (without checking :>), so there's probably some kind of #ifdef to automatically exclude it. If that's how things are setup at present, would the optimal approach be to adjust such an #ifdef to also exclude OSX?
Unfortunately the systemd code is compiled everywhere. We use no library or header file. AFAIK the only way we communicate with systemd is DBus (and one socket maybe), anyway if that's not available we just fallback without an error, so the code is designed to work with or without systemd, no need to recompile anything. OTOH it adds unused code for platforms where it won't be used at all. At least for now ;)
Thanks Martin. :) I'll put more time into investigating why the patch barfed for me. I think it'll just be something simple like forgetting to set the time/date stamp of the patched file so make doesn't try to regenerate ./configure again. Will find out. ;) Regards and best wishes, Justin Clift -- "My grandfather once told me that there are two kinds of people: those who work and those who take the credit. He told me to try to be in the first group; there was less competition there." - Indira Gandhi