Re: [PATCH v2] qemuProcessStop: Reattach NVMe disks a domain is mirroring into
On Thu, May 07, 2020 at 11:50:40 +0200, Michal Privoznik wrote:
In v5.10.0-rc1~42 (which was later fixed in v6.0.0-rc1~487) I am
removing XATTRs for a file that QEMU is mirroring a disk into but
it is killed meanwhile. Well, we can call
qemuSecurityRestoreImageLabel() which will not only remove XATTRs
but also use them to restore the original owner of the file.
Moreover, if the mirror destination is not a file but a NVMe
disk, then call qemuHostdevReAttachOneNVMeDisk() to reattach the
NVMe back to the host.
All of this would be done by blockjob code when the job finishes,
but in this case the job won't finish - QEMU is killed meanwhile.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1825785
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
IMO there are two things done in this commit. I agree with both but I
don't agree with having them both in same commit.
You can use:
Reviewed-by: Peter Krempa <pkrempa(a)redhat.com>
On the both fragments without the need to re-send.