On 05/13/2013 11:01 AM, John Ferlan wrote:
If the <sysinfo> system table 'uuid' field is
improperly formatted,
then qemu will fail to start the guest with the error:
virsh start dom
error: Failed to start domain dom
error: internal error process exited while connecting to monitor: Invalid SMBIOS UUID
string
This was because the parsing rules were lax with respect to allowing extraneous
spaces and dashes in the provided UUID. As long as there were 32 hexavalues
that matched the UUID for the domain the string was accepted. However startup
failed because the string format wasn't correct. This patch will adjust the
string format so that when it's presented to the driver it's in the expected
format.
Addded a test for uuid comparison within sysinfo.
s/Addded/Added/
---
src/conf/domain_conf.c | 54 ++++++++++++++--------
.../qemuxml2argv-smbios-uuid-match.xml | 23 +++++++++
tests/qemuxml2argvtest.c | 1 +
3 files changed, 58 insertions(+), 20 deletions(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-smbios-uuid-match.xml
ACK.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library
http://libvirt.org