Re: [libvirt] PATCH: Work in progress suport for video device config

On Tuesday 19 May 2009 11:35:40 Daniel P. Berrange wrote: > diff -r 66fa9bfc797c src/domain_conf.h > --- a/src/domain_conf.h Mon May 18 11:28:46 2009 +0100 > +++ b/src/domain_conf.h Mon May 18 11:29:00 2009 +0100 > @@ -264,6 +264,25 @@ struct _virDomainSoundDef { > int model; > }; > > + > +enum virDomainVideoType { > + VIR_DOMAIN_VIDEO_TYPE_VGA, > + VIR_DOMAIN_VIDEO_TYPE_CIRRUS, > + VIR_DOMAIN_VIDEO_TYPE_VMVGA, > + VIR_DOMAIN_VIDEO_TYPE_XEN, can we add VIR_DOMAIN_VIDEO_TYPE_VBOX as well here, cause the the graphics adapter shows up as "VirtualBox Graphics Adapter" in hardware list and has its own drivers installed via the guest additions.

> + > + VIR_DOMAIN_VIDEO_TYPE_LAST > +}; > + > + > +typedef struct _virDomainVideoDef virDomainVideoDef; > +typedef virDomainVideoDef *virDomainVideoDefPtr; > +struct _virDomainVideoDef { > + int type; > + unsigned int vram; > + unsigned int heads; can we add "unsigned int 3dSupport;" here cause VirtualBox has support for 3d acceleration and it needs to be specified in video adapter category. (it is not boolean, but an int cause there could be multiple option, like supporting acceleration via opengl, directx, etc, just trying to be future proof.. :) )