15 Mar
2017
15 Mar
'17
6:59 p.m.
[...]
4. Using virPCIDeviceAddressPtr in getSCSIHostNumber and getAdapterName. Ironically the "original" series I had passed along the virStorageAdapterSCSIHostPtr, but since it's been decreed that a src/util function cannot include a src/conf header, I had to back that off.
But virPCIDeviceAddressPtr is defined in src/util/virpci.c. There are *other* address types that are defined in conf (e.g. virDomainDeviceDriveAddress), but not PCI addresses.
Well _virPCIDeviceAddress is in virpci.c, but virPCIDeviceAddressPtr is in virpci.h... I could change virSCSIHostGetNameByParentaddr to take a virPCIDeviceAddressPtr and a unique_id - but I'll let that be separate from this series because there's way too much going on already. John