Re: [libvirt] [PATCH] Introduce virt-console
On Thu, Jan 15, 2009 at 01:40:03PM +0000, Richard W.M. Jones wrote:
Doesn't working STREAMS exist on UnixWare too? I still think the
UnixWare? Seriously?
right thing to do is to detect STREAMS. If someone installs broken
STREAMS on Linux, then it is their responsibility to find a more
They're not broken - installing the STREAMS support doesn't magically
rewrite the Linux kernel pty code to use it.
You seem to be arguing that I should introduce potential bugs, with zero
benefit.
> Of course, my preferred fix would be for Solaris to drop
STREAMS, but
> that's a vain hope :)
There's the problem - if Solaris drop streams, the #ifdef __sun checks
will be incorrect.
No - if this ever happens, it will not break pty-using code. Again, what
test are you thinking of to detect that the pty code is STREAMS based?
I'm not being obstructive here - I genuinely cannot conceive what such a
test would look like.
regards,
john