Re: [all PATCH] gitlab: add CI job for validating DCO signoff
On Wed, 2020-04-22 at 15:37 +0100, Daniel P. Berrangé wrote:
+# Check that all commits are signed-off for the DCO. Skip
+# on master branch and -maint branches, since we only need
+# to test developer's personal branches.
+check-dco:
+ stage: prebuild
+ image: registry.gitlab.com/libvirt/libvirt-ci/check-dco:master
+ script:
+ - /check-dco
+ only:
+ - branches
+ except:
+ - master
You're not actually skipping the -maint branches here, so either
you need to change this to
except:
- /^v.*-maint$/
- master
which libvirt currently uses, or to drop the mention of -maint
branches from the comment.
Why is it that we want to skip those branches, anyway? I get why
they're not necessary in a MR-based workflow, but we're not quite
there yet...
Actually, now that we're using GitLab as the primary repository,
how are we ensuring commits without DCO don't slip in? We had a
hook that took care of that on libvirt.org - was something like
that introduced on GitLab?
--
Andrea Bolognani / Red Hat / Virtualization