Re: [libvirt] [PATCH] qemu: Support for overriding NOFILE limit

On 12/22/2011 06:14 AM, Michal Privoznik wrote: > This patch adds max_files option to qemu.conf which can be used to > override system default limit on number of opened files that are > allowed for qemu user. > --- > src/qemu/libvirtd_qemu.aug | 1 + > src/qemu/qemu.conf | 4 +++- > src/qemu/qemu_conf.c | 4 ++++ > src/qemu/qemu_conf.h | 1 + > src/qemu/qemu_process.c | 16 ++++++++++++++-- > src/qemu/test_libvirtd_qemu.aug | 4 ++++ > 6 files changed, 27 insertions(+), 3 deletions(-) ACK with grammar nits - looks like straight-forward extension of an existing idiom for increasing limits. > +++ b/src/qemu/qemu.conf > @@ -301,9 +301,11 @@ > > # If max_processes is set to a positive integer, libvirt will use it to set pre-existing, but: /to set$/to set the/ > # maximum number of processes that can be run by qemu user. This can be used to > -# override default value set by host OS. > +# override default value set by host OS. The same apply to max_files which s/apply/applies/ > +# set limit to maximum number of opened files. s/set limit to/sets the limit on the/