Re: [libvirt] PATCH: 9/12: HAL/DevitKit node device impl

> > + (void)get_int_prop(ctx, udi, "pci.vendor_id", (int *)&d->pci_dev.vendor); > > + if (get_str_prop(ctx, udi, "pci.vendor", &d->pci_dev.vendor_name) != 0) > > + (void)get_str_prop(ctx, udi, "info.vendor", &d->pci_dev.vendor_name); > > + (void)get_int_prop(ctx, udi, "pci.product_id", (int *)&d->pci_dev.product); > > + if (get_str_prop(ctx, udi, "pci.product", &d->pci_dev.product_name) != 0) > > + (void)get_str_prop(ctx, udi, "info.product", &d->pci_dev.product_name); > > By the way - vendor and product IDs are normally quoted in hex, not > decimal - e.g. I'd know my NIC is 8086:10de, not 32902:4318 > > I guess most other integer values in libvirt XML are decimal, but might > be worth adding a hex format for this? I'd prefer hex for vid/pid as well; I just stuck with decimal since the rest of libvirt does. If this does get changed to output hex, I'd only request that we prefix hex numbers with "0x" so people don't have to remember which attrs are dumped in hex and which in decimal.