On 1/28/2022 10:05 AM, Michal Prívozník wrote:
On 1/25/22 17:19, Praveen K Paladugu wrote:
This patchset adds support for cgroup management of ch threads. This version correctly manages cgroups for vcpu and emulator threads created by ch. cgroup management for iothreads is not yet supported.
Along with cgroup management, this patchset also enables support for pinning vcpu and emulator threads to selected host cpus.
And also does a lot of formatting changes back and forth. I'm not fond of that really. If you want to clean up the formatting please do so in a separate patch(set).
Michal, My apologies for the churn related to formatting. I ran "GNU intend" these patches assuming that would correctly handle all the formatting. That caused a ton of formatting issues, I tried to revert most of it. Seems like I missed a few instances. I will pay attention to the formatting in the follow up submissions. I took note of Persistent Def and handling of NUMA Nodeset in cloud-hypervisor. The original author for this patch is no longer with Microsoft. I will take some time to figure this out and submit patches are necessary. Appreciate your support with merging this patch set.
src/ch/ch_conf.c | 2 + src/ch/ch_conf.h | 4 +- src/ch/ch_domain.c | 64 ++++ src/ch/ch_domain.h | 18 +- src/ch/ch_driver.c | 590 +++++++++++++++++++++++++++++++++ src/ch/ch_monitor.c | 156 +++++++++ src/ch/ch_monitor.h | 56 +++- src/ch/ch_process.c | 385 ++++++++++++++++++++- src/ch/ch_process.h | 3 + src/hypervisor/domain_cgroup.c | 457 ++++++++++++++++++++++++- src/hypervisor/domain_cgroup.h | 72 ++++ src/libvirt_private.syms | 14 +- src/qemu/qemu_cgroup.c | 413 +---------------------- src/qemu/qemu_cgroup.h | 11 - src/qemu/qemu_driver.c | 14 +- src/qemu/qemu_hotplug.c | 7 +- src/qemu/qemu_process.c | 24 +- 17 files changed, 1835 insertions(+), 455 deletions(-)
Nevertheless, I'm fixing all the issues I've raised and merging.
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
Michal
-- Regards, Praveen K Paladugu