Re: [libvirt] [PATCH 3/4] schema: Introduce schema for the news.xml file
On Tue, 2017-03-28 at 13:58 +0200, Peter Krempa wrote:
[...]
@@ -18,6 +18,8 @@
each <section> tag is required to contain at least one <change> tag.
Lines should be kept under 80 columns, and should not exceed 100 columns.
+
+ This file is validated against docs/news.rng schema.
It's actually docs/schemas/news.rng ;)
[...]
@@ -0,0 +1,73 @@
+<?xml version="1.0"?>
+<grammar xmlns="http://relaxng.org/ns/structure/1.0"
datatypeLibrary="http://www.w3.org/2001/XMLSchema-datatypes">
I would put datatypeLibrary= right under xmlns=, but it's
okay either way.
I'm no RNG expert, but the schema looks fine to me.
@@ -237,6 +237,8 @@ mymain(void)
DO_TEST("storagevol.rng", "storagevolxml2xmlin",
"storagevolxml2xmlout",
"storagevolschemadata");
+ DO_TEST_FILE("news.rng", "../docs/news.xml");
You'll want to deal with how this interacts with VPATH
builds, as mentioned by Martin.
--
Andrea Bolognani / Red Hat / Virtualization