Re: [libvirt] [jenkins-ci PATCH 2/6] mappings: add pulseaudio libs for native packages
On Thu, May 09, 2019 at 04:25:03PM +0200, Andrea Bolognani wrote:
On Fri, 2019-05-03 at 19:02 +0100, Daniel P. Berrangé wrote:
> Subject: mappings: add pulseaudio libs for native packages
Again, this can be
mappings: Add PulseAudio
[...]
> + pulseaudio:
> + rpm: pulseaudio-libs-devel
> + deb: libpulse-dev
Lines are not in alphabetical order.
More importantly, shouldn't this have
cross-policy-deb: foreign
as well?
Unrelated to this patch, but does our default of 'native' for
cross-policy really make sense? Unless I'm mistaken, that's the
value we need for tools rather than libraries, and in general
projects depend on way more libraries than they do on tools, so
perhaps it would make sense to make 'foreign' the default and
use 'native' explicitly for tools only.
'native' by default was done as it is the safe option. ie if you
don't mark a package for foreign install, the container image will
still build fine. If it was the reverse, then we'd get either
errors from apt failing to resolve deps, or worse yet, it can
even uninstall the native tool & add the foreign build which
then won't work at runtime.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|