Re: [libvirt] [RFC PATCH] Support for qemu aio drive option
On 04/20/2010 03:23 PM, Matthias Bolte wrote:
> This is a decent start, but it's still missing XML
definition, remote
> protocol support, and virsh support. docs/api_extension gives a sample
> patch series that shows all the pieces that are necessary for enhancing
> the API.
This is just an domain XML extension. Why does it need remote protocol
support or virsh support?
That would be my inexperience with major additions showing through; I
was assuming that this required remote support, but you may indeed be
correct that it is more localized than that. Sorry if I accidentally
overstated the scope of this addition.
Parts that are really missing: Documenting this new domain XML
attribute in docs/formatdomain.html.in and updating the
docs/schemas/domain.rng. Once that done I would consider this patch as
complete.
Agreed - without the change in docs/schemas/domain.rng, the existing
patch cannot ever be fed validated XML that includes the new attribute
in the first place.
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)