Re: [libvirt] [PATCH] qemud: don't dereference NULL on failed virGetUserDirectory
On Fri, Jan 23, 2009 at 02:23:14PM +0100, Jim Meyering wrote:
Jim Meyering <jim(a)meyering.net> wrote:
> I spotted this while merging my unix_sock_dir changes:
...
> char *userdir = virGetUserDirectory(NULL, uid);
> + if (userdir == NULL) {
> + /* give no diagnostic here; virGetUserDirectory reports OOM */
It can also fail due to getpwuid_r failure.
Here's the patch with corrected comment/log:
ACK
Daniel
--
|: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :|
|: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|