Re: [libvirt] [PATCH 1/2] devices: filesystems: added volume type

On Fri, Apr 08, 2016 at 07:39:23PM +0300, Olga Krishtal wrote: > New type of <devices> <filesystem type= 'volume'> is introduced. > This patch allows to use volumes for storing the filesystem, that is > accessed from the guest e.g. root directory for container. > > To take advantage of volumes as a backend of filesystem volume > and pool names should be specified: > <filesystem type= 'volume'> > <source pool='pool name' volume='volume name'/> > > Signed-off-by: Olga Krishtal <okrishtal(a)virtuozzo.com&gt; > --- > src/conf/domain_audit.c | 4 ++-- > src/conf/domain_conf.c | 54 > +++++++++++++++++++++++++++++++++++----------- > src/conf/domain_conf.h | 4 +++- > src/libvirt_private.syms | 1 + > src/lxc/lxc_cgroup.c | 2 +- > src/lxc/lxc_container.c | 50 > +++++++++++++++++++++--------------------- > src/lxc/lxc_controller.c | 18 ++++++++-------- > src/lxc/lxc_native.c | 5 +++-- > src/lxc/lxc_process.c | 2 +- > src/openvz/openvz_conf.c | 4 ++-- > src/openvz/openvz_driver.c | 4 ++-- > src/qemu/qemu_command.c | 2 +- > src/vbox/vbox_common.c | 6 +++--- > src/vmx/vmx.c | 4 ++-- > src/vz/vz_sdk.c | 10 ++++----- > 15 files changed, 102 insertions(+), 68 deletions(-) > Looks good to me, but I do not feel competent to comment on the vz* part. Also, could you please separate the changes adapting from ->src to ->src->path from the changes adding the new type? Jan