Re: [libvirt] [PATCH RFC 3/5] qemu: Implement period and quota tunable XML configuration and parsing.

15 Jun 2011

On 06/15/2011 01:31 AM, Wen Congyang wrote:
...

diff --git a/src/conf/domain_conf.h b/src/conf/domain_conf.h
index 3ef48d1..d2a5804 100644
--- a/src/conf/domain_conf.h
+++ b/src/conf/domain_conf.h
@@ -1151,6 +1151,8 @@ struct _virDomainDef {
struct {
         unsigned long shares;
+        unsigned long long period;
+        long long quota;
         int nvcpupin;
         virDomainVcpupinDefPtr *vcpupin;
     } cputune;
I think you are incorrectly mixing types here with quota and period.
Shouldn't both of these be unsigned long long (or maybe _virCfsQuota as
I suggested in an earlier email)?

-- 
Adam Litke
IBM Linux Technology Center

    