Re: [libvirt] [PATCH] qemu: hotplug: unify "not found" logs when detaching device

On 12/14/2017 06:16 AM, Chen Hanxiao wrote: > From: Chen Hanxiao <chenhanxiao(a)gmail.com&gt; > > Some services, such as Nova, check whether device was not found > by errror messages "not found". [1] error > > This patch unify logs of qemuDomainDetachDeviceLive, which will be helpful. > > [1] https://github.com/openstack/nova/blob/master/nova/virt/libvirt/guest.py#... > > Signed-off-by: Chen Hanxiao <chenhanxiao(a)gmail.com&gt; > --- > src/qemu/qemu_hotplug.c | 18 +++++++++++------- > 1 file changed, 11 insertions(+), 7 deletions(-) > Something about a tool that parses the error message(s) looking for a specific message string in English and needing to alter libvirt sources to match that tools' needs strikes me as incorrect and a "slippery slope" to follow. I'm not in favor of this because we'll be constantly chasing these types of bugs to match some other tools' (what I think is) incorrect means to handle errors.