Re: [libvirt] [PATCH v4 1/3] add new virDomainCoreDumpWithFormat API

> diff --git a/src/test/test_driver.c b/src/test/test_driver.c > index b724f82..605b0d1 100644 > --- a/src/test/test_driver.c > +++ b/src/test/test_driver.c > @@ -2427,9 +2427,10 @@ testDomainRestore(virConnectPtr conn, > return testDomainRestoreFlags(conn, path, NULL, 0); > } > > -static int testDomainCoreDump(virDomainPtr domain, > - const char *to, > - unsigned int flags) > +static int testDomainCoreDumpWithFormat(virDomainPtr domain, > + const char *to, > + unsigned int dumpformat, > + unsigned int flags) > { > testConnPtr privconn = domain->conn->privateData; > int fd = -1; > @@ -2479,6 +2480,12 @@ static int testDomainCoreDump(virDomainPtr domain, > } > } > > + if (dumpformat> VIR_DUMP_FORMAT_KDUMP_SNAPPY) { > + virReportSystemError(errno, > + _("invalid value of dumpformat: %d"), dumpformat); > + goto cleanup; > + } This should be done in the libvirt.c entry point, comparing against VIR_DUMP_FORMAT_LAST

Regards, Daniel