Re: [PATCH] virnwfilterobj: Don't use virObjectLockGuard() with virNWFilterObj
On Fri, Mar 18, 2022 at 11:43:34AM +0100, Michal Privoznik wrote:
While its name would suggest that virNWFilterObj is an actual
virObject it is not. It's a plain structure (with virMutex as its
first member). Therefore, when locking the struct
virObjectLockGuard() can' be used and virLockGuardLock() must be
used instead.
Spotted-by: Martin Kletzander <mkletzan(a)redhat.com>
Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com>
---
This fixes the crasher in the integration CI we saw yesterday:
Reviewed-by: Erik Skultety <eskultet(a)redhat.com>
After this patch, there's still a deadlock [1], but you should push this fix in
the meantime.
[1] https://paste.centos.org/view/6a7bfd66