Re: [libvirt] [PATCH 03/10] conf: domaincaps: Fix broken attempt at being const-correct

On Tue, Nov 12, 2019 at 08:27:40AM +0100, Peter Krempa wrote: > 'virBlahPtr const blah' results into modification to the value of 'blah' > triggering compilation error rather than the modification of the virBlah > struct the pointer points to. Shall we add a syntax check rule to forbid "virFOOPtr const", and "const virFOOPtr".

Indeed, I rather wish we never had the "Ptr" suffix at all, and just used a "*" normally, but that would be a too huge change. > > All of the domain capability formatting code was broken in this regard. > > Signed-off-by: Peter Krempa <pkrempa(a)redhat.com&gt; > --- > src/conf/domain_capabilities.c | 32 ++++++++++++++++---------------- > src/conf/domain_capabilities.h | 4 ++-- > 2 files changed, 18 insertions(+), 18 deletions(-) >