Re: [libvirt] [PATCH 09/41] remote: conditionalize driver loading in libvirtd daemon

26 Jul 2019


      On Tue, 2019-07-23 at 17:02 +0100, Daniel P. Berrangé wrote:
[...]
...
+++ b/src/remote/remote_daemon.c
@@ -303,6 +303,10 @@ static int daemonErrorLogFilter(virErrorPtr err, int priority)
static int daemonInitialize(void)
 {
+#ifdef MODULE_NAME
+    if (virDriverLoadModule(MODULE_NAME, MODULE_NAME "Register", true) < 0)
+        return -1;
Perhaps a short comment along the lines of what you explained in
the commit message would be in order here?

Regardless,

  Reviewed-by: Andrea Bolognani <abologna@redhat.com>

-- 
Andrea Bolognani / Red Hat / Virtualization

    