Re: [libvirt] [PATCH 8/9] qemu: capabilities: Lock out incremental backup capability without blockdev
On 11/25/19 7:53 AM, Peter Krempa wrote:
Blockdev is required to do incremental backups properly. Add a
helper
function for locking out capabilities and export it to allow re-doing
the processing if a different code path modifies capabilities.
Signed-off-by: Peter Krempa <pkrempa(a)redhat.com>
---
src/qemu/qemu_capabilities.c | 17 +++++++++++++++++
src/qemu/qemu_capabilities.h | 2 ++
2 files changed, 19 insertions(+)
Reviewed-by: Cole Robinson <crobinso(a)redhat.com>
this made me go look at the case that _BLOCKDEV is disabled. bus='sd',
hmm that's unfortunate. Do you know if there's qemu plans to make it
-blockdev compatible? Maybe -machine option like was done with -pflash?
Or are we stuck with that indefinitely?
Thanks,
Cole