Re: [libvirt] [PATCH 5/5] vcpupin: add query option to virsh vcpupin command
On 06/24/2011 04:56 PM, Eric Blake wrote:
> When --query is specified, cpulist is not required and vcpu
number
> is optional. When vcpu number is provided, information of only specified
> vcpu is displayed.
But why do we need --query? If cpulist and --query are orthogonal, why
not just make the absence of a cpulist imply query, without having it be
an explicit option?
For the record, I got the idea from 'virsh memtune', which is another
command where omitting options performs a query. Since no other command
has a --query, we didn't need to add one here. My fault for not
realizing that when I first mentioned it in:
http://www.redhat.com/archives/libvir-list/2011-June/msg00500.html
which is why I didn't mind fixing it :)
--
Eric Blake eblake(a)redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
Attachments:
- signature.asc (application/pgp-signature — 619 bytes)