Re: [Libvir] [PATCH] Synchronous daemon restart
On Wed, May 02, 2007 at 05:50:41PM +0100, Mark McLoughlin wrote:
Hey,
See:
https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=238492
Basically, doing a "service libvirtd restart", you see:
libvirt-qemud: Failed to autostart network 'default': cannot create bridge
'virbr0' : File exists
and the default network is broken.
The problem turns out to be that the initscript doesn't wait before the
old daemon has shut down before starting the new one.
The fix is simple - if you don't pass a kill level argument to
killproc(), then it will block for a few seconds until the daemon has
shutdown before killing it with a SIGKILL.
Looks fine to me. While you're at it, can you also add a 'reload' command
to the initscript which -HUPs the daemon to make it reload it config
and reset the IPtables rules.
Dan.
--
|=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=|
|=- Perl modules: http://search.cpan.org/~danberr/ -=|
|=- Projects: http://freshmeat.net/~danielpb/ -=|
|=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|