Re: [libvirt] [PATCH] fs: Fix pool building when directory already exists

On Fri, Jul 17, 2015 at 10:12:44AM +0200, Christophe Fergeau wrote: >Currently, when trying to virsh pool-define/virsh pool-build a new >'dir' pool, if the target directory already exists, virsh >pool-build/virStoragePoolBuild will error out. This is a change of >behaviour compared to eg libvirt 1.2.13 > >This is caused by the wrong type being used for the dir_create_flags >variable in virStorageBackendFileSystemBuild , it's defined as a bool >but is used as a flag bit field so should be unsigned int (this matches >the type virDirCreate expects for this variable). > >This should fix https://bugzilla.gnome.org/show_bug.cgi?id=752417 (GNOME >Boxes) and https://bugzilla.redhat.com/show_bug.cgi?id=1244080 >(downstream virt-manager). >--- >src/storage/storage_backend_fs.c | 3 ++- >1 file changed, 2 insertions(+), 1 deletion(-) > ACK, this should also be back-ported to v1.2.16-maint and v1.2.17-maint branches.