Re: [libvirt] [PATCH v2 2/8] blockcopy: split out virsh implementation

On 08/26/14 13:21, Eric Blake wrote: > I'm about to extend the capabilities of blockcopy. Hiding a few > common lines of implementation gets in the way of the new required > logic, and putting the new logic in the common implementation won't > benefit any of the other blockjob operations. Therefore, it is > simpler to just do the work inline. > > * tools/virsh-domain.c (blockJobImpl): Drop unused variable. Move

> virDomainPtr dom = NULL; > - const char *name, *path; > + const char *path; This ... > unsigned long bandwidth = 0; > int ret = -1; > const char *base = NULL; > const char *top = NULL; > unsigned int flags = 0; > > - if (!(dom = vshCommandOptDomain(ctl, cmd, &name))) > + if (!(dom = vshCommandOptDomain(ctl, cmd, NULL))) .. and this are unrelated changes. > goto cleanup; > > if (vshCommandOptStringReq(ctl, cmd, "path", &path) < 0) ACK although I'd rather see the two changes separate.