Re: [libvirt] [PATCH 05/10] vbox: Replace atoi with virStrToLong_i

On 03/30/2010 10:20 AM, Matthias Bolte wrote: > --- >  src/vbox/vbox_tmpl.c |    4 +++- >  1 files changed, 3 insertions(+), 1 deletions(-) > > diff --git a/src/vbox/vbox_tmpl.c b/src/vbox/vbox_tmpl.c > index 05b075f..07996d4 100644 > --- a/src/vbox/vbox_tmpl.c > +++ b/src/vbox/vbox_tmpl.c > @@ -598,7 +598,9 @@ static int PRUnicharToInt(PRUnichar *strUtf16) { >      if (!strUtf8) >          return -1; > > -    ret = atoi(strUtf8); > +    if (virStrToLong_i(strUtf8, NULL, 10, &ret) < 0) > +        return -1; > + >      g_pVBoxGlobalData->pFuncs->pfnUtf8Free(strUtf8); Oops.  Memory leak if strUtf8 was not valid.