On Tue, May 16, 2017 at 01:15:59 +0300, Vasiliy Tolstov wrote:
Signed-off-by: Vasiliy Tolstov <v.tolstov@selfip.ru> --- docs/formatdomain.html.in | 21 +++++++++++++++++++++ docs/schemas/domaincommon.rng | 11 +++++++++++ src/conf/domain_conf.c | 28 ++++++++++++++++++++++++++++ src/conf/domain_conf.h | 1 + src/qemu/qemu_hotplug.c | 17 +++++++++++++++++ src/qemu/qemu_interface.c | 8 ++++---- 6 files changed, 82 insertions(+), 4 deletions(-)
diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in index 8c884f4af9cb..dd8e6a4afa99 100644 --- a/docs/formatdomain.html.in +++ b/docs/formatdomain.html.in @@ -5421,6 +5421,27 @@ qemu-kvm -net nic,model=? /dev/null <span class="since">Since 0.9.5</span> </p>
+ <h5><a name="elementHostLink">Modifying phisical link state</a></h5> +<pre> +... +<devices> + <interface type='ethernet'> + <source> + <b><link state='down'/></b> + <target dev='vnet0'/> + </interface> +</devices> +...</pre> + + <p> + This element provides means of setting state of the phisical network interface. + Possible values for attribute <code>state</code> are <code>up</code> and + <code>down</code>. If <code>down</code> is specified as the value, the interface + put in down state. Default behavior if this element is unspecified is to have the + link state <code>up</code>. + <span class="since">Since 3.3.2</span>
3.3.2? We dropped micro versions some time ago.
+ </p> + <h5><a name="mtu">MTU configuration</a></h5> <pre>
There already is an element called <link> with attribute "state" which modifies the link state in qemu. So that maps to guest link state. So this patch has a naming collision going on. I also don't really see how modifying the host side link state would be useful. Could you elaborate why you think it would be useful? At any rate, if you provide a justification, you also need to modify the XML portion to have a separate element and provide a test case as it's required with XML changes.