Re: [libvirt] [PATCHv3 10/12] qemu: conf: Add support for memory device cold(un)plug

>> I have tested your series with our qemu memory hot remove patch series, >> here would be a possible error. >> >> When hotplug a memory device, its size has been aligned. So the >> compare for >> size here would fail possiblely. >> > hmm.. Not sure that's necessary - although Peter can make the final > determination... Commit id '57b215a' doesn't modify each def->mems[i] > entry in qemuDomainAlignMemorySizes, rather it gets a value from > virDomainDefSetMemoryInitial and then does the rounding. > > If the stored def->mems[i]->size value is/was modified, then I'd agree, > but it doesn't appear to be that way. > > If there is a rounding of the value - then please just point it out Yes, the stored def->mems[i]->size value was modified. If you assign the size 524287 KiB, the stored value will be 524288. Thanks, Zhu