Re: [libvirt] [PATCH 2/3] Managed save compression flags.

On 08/13/10 - 04:06:24PM, Daniel P. Berrange wrote: > On Fri, Aug 13, 2010 at 10:53:48AM -0400, Chris Lalancette wrote: >> Add in the ability to specify compression flags from the >> managed save API. We map these to the supported QEMU >> compression flags internally. > > I'm not really convinced we need todo this. I think the host > level setting in /etc/libvirt/qemu.conf is sufficient already. Don't get me wrong, I don't think this is a killer feature. But when I initially implemented compression, I definitely would have done it through the API if we had had a "flags" parameter available for virDomainSave(). Now that we have a ManagedSave that does have a flags parameter, I figured we do it the right way. I think it's a little cleaner, and more intuitive, to do it through the API, and it makes the feature available to hypervisors other than qemu.